Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement strict null checks #563

Merged
merged 13 commits into from
Jan 15, 2025
Merged

feat: implement strict null checks #563

merged 13 commits into from
Jan 15, 2025

Conversation

yassinedorbozgithub
Copy link
Collaborator

Motivation

The main motivation is to implement strict null checks

Fixes #562

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@yassinedorbozgithub yassinedorbozgithub added the enhancement New feature or request label Jan 13, 2025
@yassinedorbozgithub yassinedorbozgithub self-assigned this Jan 13, 2025
@yassinedorbozgithub yassinedorbozgithub changed the title feat: implement strict null check feat: implement strict null checks Jan 13, 2025
@yassinedorbozgithub yassinedorbozgithub added strictNullChecks and removed enhancement New feature or request labels Jan 14, 2025
@yassinedorbozgithub yassinedorbozgithub changed the base branch from 545-issue-chat-module-strictnullchecks-issues to main January 15, 2025 10:54
marrouchi
marrouchi requested changes Jan 15, 2025
View reviewed changes
api/src/attachment/controllers/attachment.controller.ts Outdated Show resolved Hide resolved
api/src/extensions/helpers/llm-nlu/index.helper.ts Outdated Show resolved Hide resolved
api/src/extensions/helpers/llm-nlu/index.helper.ts Outdated Show resolved Hide resolved
api/tsconfig.json
@@ -13,7 +13,7 @@
"baseUrl": "./",
"incremental": true,
"skipLibCheck": true,
"strictNullChecks": false,
"strictNullChecks": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"strictNullChecks": true,
"strictNullChecks": true,

Is this the last PR ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

api/src/utils/pipes/object-id.pipe.ts Outdated Show resolved Hide resolved
api/src/nlp/controllers/nlp-value.controller.spec.ts Outdated Show resolved Hide resolved
@marrouchi marrouchi merged commit 47e8056 into main Jan 15, 2025
5 checks passed
@yassinedorbozgithub yassinedorbozgithub linked an issue Jan 15, 2025 that may be closed by this pull request
🤔 [ISSUE] - strict null check #562
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamedAliBouhaouala MohamedAliBouhaouala MohamedAliBouhaouala approved these changes

@abdou6666 abdou6666 abdou6666 left review comments

@marrouchi marrouchi marrouchi approved these changes

Assignees

@yassinedorbozgithub yassinedorbozgithub

Labels
strictNullChecks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - strict null check
4 participants
@yassinedorbozgithub @marrouchi @abdou6666 @MohamedAliBouhaouala